Skip to content

Conversation

IlyasMoutawwakil
Copy link
Member

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@IlyasMoutawwakil
Copy link
Member Author

@echarlaix it seems that the TFLite CI is necessary to run to see some failures 🥲
I enabled it for now to avoid any problems, it's fully distributed so shouldn't add an enormous load/wait time.

@IlyasMoutawwakil
Copy link
Member Author

IlyasMoutawwakil commented Jun 27, 2025

The core problem seems to be the fact that the tflite exporter uses different APIs (maybe just old) than the onnx exporter (like taking input shapes as input during construction of config).

@IlyasMoutawwakil IlyasMoutawwakil marked this pull request as ready for review June 27, 2025 15:23
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@echarlaix
Copy link
Collaborator

Thanks a lot for checking this @IlyasMoutawwakil ! Looks like optimum TFLite export usage is pretty low, wondering if we should either deprecate if completely in v2 or move everything to optimum-tflite, what do you think?

@IlyasMoutawwakil
Copy link
Member Author

IlyasMoutawwakil commented Jun 27, 2025

@echarlaix with the deprecation/removal of TensorFlow in Transformers, I think it only makes sense to deprecate/remove it from optimum, onnx format is imo the universal format for model export from which other frameworks should be able to build their representation (they usually can !)

@IlyasMoutawwakil
Copy link
Member Author

for example https://github.com/MPolaris/onnx2tflite

@IlyasMoutawwakil IlyasMoutawwakil merged commit ec756fd into main Jun 27, 2025
42 of 46 checks passed
@IlyasMoutawwakil IlyasMoutawwakil deleted the fix-tflite-and-enable-it-ci branch June 27, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants