Skip to content

Conversation

@Todd-L-Miller
Copy link
Member

@Todd-L-Miller Todd-L-Miller commented Nov 17, 2025

Passes (arbitrary) ClassAd data from the job ad into the plug-in(s). At BrianB's request, we now also do this for all multilfile / protocol version 2 plug-ins, but in a wasteful way that assumes they all speak fluent ClassAd.

HTCondor Pull Request Checklist for internal reviewers

  • Verify that (GitHub thinks) the merge is clean. If it isn't, and you're confident you can resolve the conflicts, do so. Otherwise, send it back to the original developer.
  • Verify that the related Jira ticket exists and has a target version number and that it is correct.
  • Verify that the Jira ticket is in review status and is assigned to the reviewer.
  • Verify that the Jira ticket (HTCONDOR-xxx) is mentioned at the beginning of the title. Edit it, if not
  • Verify that the branch destination of the PR matches the target version of the ticket
  • Check for correctness of change
  • Check for regression test(s) of new features and bugfixes (if the feature doesn't require root)
  • Check for documentation, if needed (documentation build logs)
  • Check for version history, if needed
  • Check BaTLab dashboard for successful build (https://batlab.chtc.wisc.edu/results/workspace.php) and test for either the PR or a workspace build by the developer that has the Jira ticket as a comment.
  • Check that each commit message references the Jira ticket (HTCONDOR-xxx)

After the above

  • Hit the merge button if the pull request is approved and it is not a security patch (security changes require 2 additional reviews)
  • If the pull request is approved, take the ticket out of review state
  • Assign JIRA Ticket back to the developer

This reverts commit b5b6ace, which does
not do what it says on the tin at all.
…tart,

honor the relevant environment variables.
@Todd-L-Miller Todd-L-Miller marked this pull request as ready for review December 4, 2025 22:08
@Todd-L-Miller Todd-L-Miller requested a review from johnkn December 8, 2025 20:18
Copy link
Contributor

@johnkn johnkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few typos in the prose, v3 vs v4.

@Todd-L-Miller Todd-L-Miller requested a review from johnkn December 16, 2025 18:32
Copy link
Contributor

@johnkn johnkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have a look at the one comment, you might want to change that.

@Todd-L-Miller Todd-L-Miller merged commit 9faa669 into main Dec 19, 2025
2 of 16 checks passed
@Todd-L-Miller Todd-L-Miller deleted the V25_4-HTCONDOR-3357-bb-branch branch December 19, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants