feat(readBody): support formdata type #1164
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| const text = await event.req.text(); | ||
| const contentType = event.req.headers.get("content-type") || ""; | ||
|
|
||
| if (contentType.startsWith("multipart/form-data")) |
There was a problem hiding this comment.
We should make it opt-in by supporting event, opts?: { type: "json" | formData" } and throw an HTTPError if it is not.
There was a problem hiding this comment.
We should make it opt-in by supporting
event, opts?: { type: "json" | formData" }and throw an HTTPError if it is not.
i support this. but my changes remain valid, right? since opts is optional. when you specify type in opts, you're specifying a certain body type, when you're not, you're parsing any body as an object or string!
There was a problem hiding this comment.
As security measure we should make types opt-in other than JSON (so if no options only json)
No description provided.