feat: freeze app routes and config after server init #1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying h3dev with
|
| Latest commit: |
cbaae51
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4e316ba5.h3dev.pages.dev |
| Branch Preview URL: | https://feat-freeze-serve.h3dev.pages.dev |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a freeze on app for adding new routes and config after server start to resolve concerns of #1139 but it is also essential for next steps if we want to support server JIT preotimizations and native runtime (Bun) routes integration to speedup, if not frozen it will be a breaking change for users.
(this is not a security mechanism and can be easily bypassed, only DX to make sure right usage)