Skip to content

feat(serveStatic): support default and custom mimes #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 2, 2025
Merged

feat(serveStatic): support default and custom mimes #1137

merged 12 commits into from
Jul 2, 2025

Conversation

outslept
Copy link
Contributor

@outslept outslept commented Jul 1, 2025

Taken the types from https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/MIME_types/Common_types (excluding not so used like ms office related)

Closes #1136

@outslept outslept requested a review from pi0 as a code owner July 1, 2025 16:06
pi0
pi0 reviewed Jul 1, 2025
View reviewed changes
@outslept
Copy link
Contributor Author

outslept commented Jul 1, 2025

Everything should be addressed now 👀

@outslept outslept requested a review from pi0 July 1, 2025 16:34
@codecov Codecov
Copy link

codecov bot commented Jul 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/utils/internal/mime.ts 94.28% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

pi0
pi0 reviewed Jul 1, 2025
View reviewed changes
pi0
pi0 reviewed Jul 1, 2025
View reviewed changes
pi0
pi0 reviewed Jul 1, 2025
View reviewed changes
@outslept outslept requested a review from pi0 July 1, 2025 18:08
@pi0 pi0 changed the title feat(static): add default MIME types for serveStatic utility feat(serveStatic): support default and custom mimes Jul 2, 2025
pi0
pi0 approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@pi0 pi0 merged commit 50aeec0 into h3js:main Jul 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

support default and custom mimes for serveStatic

2 participants

@outslept @pi0