refactor!: only accept req for H3 and EventHandlerWithFetch fetch
#1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Canceling the idea for now. Not worth killing DX only to prevent shooting in the foot implied by runtimes. |
|
Reopening as it can be also a fatal issue for integrations, e.g if second arg uses an overlapping key like |
request for H3.fetchrequest for H3.fetch
Deploying h3dev with
|
| Latest commit: |
ba19814
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dd554023.h3dev.pages.dev |
| Branch Preview URL: | https://refactor-safe-fetch.h3dev.pages.dev |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
request for H3.fetchrequest for H3 and EventHandlerWithFetch fetch
request for H3 and EventHandlerWithFetch fetchreq for H3 and EventHandlerWithFetch fetch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch API signuture is
(req, init?); however, no other runtimes agree on this, yet called it.fetch...fetch(request, server)fetch(request, info)fetch(request, env, ctx)It might be safer to have
h3.fetchstrictly only accept a single(request). This also helps avoid wrongly added overhead if one doesexport default app.fetch(which causes recreatingRequestwith a second irrelevant arg considered RequestInit)Downside, it takes away the easy DX of doing
app.fetch("url", { headers: {} })=>app._fetch("url", { headers: {} }):( (we could call itapp.request~> #1176)