Skip to content

fix: Apply primary button styles for icon button #2121 #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2023
Merged

fix: Apply primary button styles for icon button #2121 #2137

merged 2 commits into from
Sep 18, 2023

Conversation

@marek-mihok
Copy link
Contributor

@marek-mihok marek-mihok commented Sep 13, 2023 •
edited
Loading

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included

image

Closes #2121

@marek-mihok marek-mihok marked this pull request as ready for review September 13, 2023 13:04
mturoci
mturoci requested changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok.

  • What's the reason for not using the existing Fluent.PrimaryButton instead of mimicking it with custom styles?
  • The colors doesn't look good on other themes.
  • Make this part of our visual regression testing by including the primary icon button within md docs.

@marek-mihok
Copy link
Contributor Author

marek-mihok commented Sep 14, 2023

What's the reason for not using the existing Fluent.PrimaryButton instead of mimicking it with custom styles?

@mturoci the primary button with icon only is much wider than icon button (it has horizontal padding)

@mturoci
Copy link
Collaborator

mturoci commented Sep 14, 2023

I don't understand. That's the point of the issue, isn't it? If primary=True, render a primary button. The padding is specific to primary button styles which is desired - so that people understand it's primary.

@marek-mihok marek-mihok requested a review from mturoci September 18, 2023 09:17
@mturoci mturoci merged commit 4bc771d into main Sep 18, 2023
@mturoci mturoci deleted the feat/issue-2121 branch September 18, 2023 09:29
marek-mihok added a commit that referenced this pull request Jan 15, 2024
@marek-mihok
fix: Apply primary button styles for icon button #2121 (#2137)
70cbdbe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mturoci mturoci mturoci approved these changes

@lo5 lo5 Awaiting requested review from lo5 lo5 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Primary button UI without label

2 participants

@marek-mihok @mturoci