Skip to content

feat: Show empty table groups #2103 #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Sep 19, 2023
Merged

feat: Show empty table groups #2103 #2129

merged 19 commits into from
Sep 19, 2023

Conversation

@marek-mihok
Copy link
Contributor

@marek-mihok marek-mihok commented Sep 6, 2023

The PR fulfills these requirements: (check all the apply)

  • It's submitted to the main branch.
  • When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
  • When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
  • If changes were made to ui folder, unit tests (make test) still pass.
  • New/updated tests are included
Screen.Recording.2023-09-06.at.23.32.09.mov

Closes #2103

@marek-mihok marek-mihok marked this pull request as ready for review September 6, 2023 21:35
mturoci
mturoci requested changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-mihok.

The approach overall could use some work to improve perf. Also, I don't see any tests that would check whether this works or not (neither unit tests nor visual regression ones) so please add them as well.

@marek-mihok marek-mihok requested a review from mturoci September 13, 2023 13:03
mturoci
mturoci requested changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@mturoci mturoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now.

@marek-mihok marek-mihok requested a review from mturoci September 19, 2023 13:07
@marek-mihok @mturoci
feat: show empty groups for custom groups #2103
37b037a
@marek-mihok @mturoci
chore: show empty groups - groupBy #2103
080adfd
@marek-mihok @mturoci
chore: remove log #2103
6284c0a
@marek-mihok @mturoci
feat: add missing dependency #2103
d8ce7b8
@marek-mihok @mturoci
chore: refactor grouping function #2103
a37b228
@marek-mihok @mturoci
chore: update tests #2103
2e4d077
@marek-mihok @mturoci
chore: add tests #2103
e133b71
@marek-mihok @mturoci
chore: update examples and screenshot #2103
89d475e
@marek-mihok @mturoci
chore: add tests for groupBy #2103
c3be957
@marek-mihok @mturoci
chore: re-compute group list only if necessary #2103
074d014
@marek-mihok @mturoci
chore: rename dict #2103
1a70c66
@marek-mihok @mturoci
chore: minor refactor #2103
234d555
@marek-mihok @mturoci
chore: rename dict to initialGroups #2103
6c530f8
@marek-mihok @mturoci
chore: store group names only instead of intial groups #2103
44e8f3f
@marek-mihok @mturoci
fix: group header name broken when grouped by column with time data t…
41579bd 
…ype #2103
@marek-mihok @mturoci
fix: Use correct names in filter contextual menu when col data type i…
1b1f7a7 
…s time #2103
@marek-mihok @mturoci
fix: Use valueToDateString for name prop of empty groups as well #2103
a5e56d4
@marek-mihok @mturoci
fix: Do not merge groups when grouping by multiple times in a row #2103
0b55319
@marek-mihok @mturoci
chore: Remove unnecessary todo #2103
cfdb186
@mturoci mturoci merged commit cb1150f into main Sep 19, 2023
@mturoci mturoci deleted the feat/issue-2103 branch September 19, 2023 13:53
marek-mihok added a commit that referenced this pull request Jan 15, 2024
@marek-mihok
feat: Show empty table groups #2103 (#2129)
8eb62f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mturoci mturoci mturoci approved these changes

@lo5 lo5 Awaiting requested review from lo5 lo5 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show table groups without table rows

2 participants

@marek-mihok @mturoci