fix: Prevent components from being overlapped by the table sticky header #1996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sticky header, increase other z-indexes according dialog as well #1980
mturoci
requested changes
May 31, 2023
Collaborator
mturoci
left a comment
There was a problem hiding this comment.
Thanks @marek-mihok. Is there any other alternative approach we could consider? Does side_panel need to be included in this PR as well?
Contributor
Author
|
@mturoci as agreed in a personal discussion, I'm hardcoding the z-index values for now and we need to think how to avoid z-indexes completely. I've created a separate issue for that.
Including |
3 tasks
mturoci
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a dialog being overlapped by table group sticky header. However this change does not fix the overlap for the overlay card:
Screen.Recording.2023-05-30.at.18.05.28.mov
Closes #1980