feat: Render dashboard demo app links in header and add h2o logo #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mturoci
requested changes
Apr 17, 2023
Collaborator
mturoci
left a comment
There was a problem hiding this comment.
Thanks @dthiagarajan7! Looks great with a minor exception - the header is not big enough to accommodate the logo. Let's either increase its size or (probably better) remove the fixed size and have it adjust by its content.
Contributor
Author
|
@mturoci Thank you for the feedback! I've pushed the requested change and updated the screenshots in the PR description. |
mturoci
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue
Closes #1867
Description
Updated dashboard demo app to:
Links are now accessible without needing to click the hamburger menu.
Successful Local Testing