Remove unneeded concurrency things #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The gist of this is I'm looking into why we have some nasty corner cases. This isn't it, but it's a slight optimization that could be made wrt the flow handling |
|
@lowasser Just checking in to see if this project is still alive or if you have any questions/concerns on this? |
|
@jamesward Thoughts on this? |
|
We will need @lowasser to review this. |
|
Ok. The idea here is none of these mutexes or atomicBooleans are ever used concurrently they're very sequential in their nature, so having the lock there doesn't accomplish anything. |
|
This does look safe to me. |
jamesward
approved these changes
Dec 1, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mutex and atomicBolean aren't needed in this context.
The mutex is only contained in a local variable in sequential code. It isn't shared w/ any other threads. The same with the atomic bolean.
Both of these constructs are inside the launched co-routine, and aren't shared outside. Therefore they can't help control any other shared access.