Upgrade grpc-java and protobuf #271
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jamesward
reviewed
Oct 5, 2021
jamesward
reviewed
Oct 5, 2021
jamesward
reviewed
Oct 5, 2021
jamesward
reviewed
Oct 5, 2021
|
Fixes #285 |
Closed
|
So gRPC 1.41.0 causes one of the tests to fail (which is hard to reproduce locally): And gRPC 1.38 has upgraded it's guava android dependency to one that is JDK 1.8. So it seems if we want to go above gRPC 1.37.1 it is time to bump our minimum JDK to 1.8. I think what we should do is close this PR and aim for another one that bumps everything to the latest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.