fix URL constructor deprecation warning #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR somehow doesn't trigger tests. Can you make rebase and make some empty commit to see if we can trigger them? Without successful required tests, it can't be merged. |
duckladydinh
approved these changes
Aug 24, 2025
duckladydinh
requested changes
Aug 24, 2025
f82aaa9 to
df60825
Compare
fixes the constructor deprecation of `java.net.URL` that first appeared in java 20 by replacing it with `java.net.URI.toURL()`
2e87bdf to
70738af
Compare
duckladydinh
approved these changes
Aug 25, 2025
stub/build.gradle.kts
Outdated
| } | ||
|
|
||
| tasks.withType<DokkaTask>().configureEach { | ||
|
|
There was a problem hiding this comment.
Remove this empty line.
There was a problem hiding this comment.
should be fixed now!
|
Thanks, referecing #618 (comment), I am active for a few weeks here so if you still have something you want to fix, now is the best time of the year ;) (only short changes though). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the constructor deprecation warning of
java.net.URLthat first appeared in java 20 by replacing it withjava.net.URI.toURL()closes #626