Fixed [FD-50921] - base64-encoded image files for asset creation was broken #18003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of this fix is just the call to
parent::prepareForValidation()in theStoreAssetRequest.phpfile.While I was troubleshooting this I decided to make it so that any base64-encoded data must be presented as a
data:-style URL. Unfortunately, my exception-throwing code doesn't seem to work, but the request still fails correctly if the data is not encoded correctly (i.e. as a data: URL with the base64 option).While I was in there - and to prevent us from breaking this again in the future - I added a basic test for the functionality.