Fixed #17386 - Added SAML key size to env - possible alternative to #17387 #17692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: snipe <[email protected]>
Member
Author
|
Gentle ping, @uberbrady - this seems like it should be innocuous enough, yeah? |
uberbrady
approved these changes
Aug 26, 2025
Member
uberbrady
left a comment
There was a problem hiding this comment.
This seems great! Sane default, overridable pretty easily. I'm a little curious how it will handle if you try to change the key size, but we can figure that out if it ends up happening. Thanks for making this very solid compromise!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just takes the solution proposed by @strobelm in #17387 and makes it into an environmental variable for better backwards compatibility.
Fixes #17386 and #17387