Fixed #17445 - move jobtitle under assigned_to in AssetTransformer #17446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusmoore
commented
Jul 22, 2025
app/Presenters/AssetPresenter.php
Outdated
| 'formatter' => 'employeeNumFormatter', | ||
| ],[ | ||
| 'field' => 'jobtitle', | ||
| 'field' => 'assigned_to.jobtitle', |
Collaborator
Author
There was a problem hiding this comment.
I had to double-check changing this line but it renders in the asset index properly.
Member
|
I think we need to account for this in the API controller as well tho |
Member
|
(We have |
Collaborator
Author
|
It works as is but you're thinking we should put it under |
Member
|
I think we need to pull the sortability on that or fix it. It doesn't seem to work as expected. |
Collaborator
Author
|
Ah right. I see the issue. |
Member
|
IIRC, we don't use dot notation on the fields in the presenters, we add a custom sorter scope |
Collaborator
Author
|
I think this one is ready for review now. |
snipe
reviewed
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
jobtitlefrom the top level underassigned_toin the AssetsTransformer.Fixes #17445
Follow up for ff01078