Introduce extra truthy and falsy values at instance level #1719
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
I'm on the fence between introducing a new env variable vs. trying to use document locale (but that would mean storing those lists directly in the Grist code for all possible language and is probably more work to set up and maintain i18n). Any opinion on this ? |
|
Another question: Is it intended not to document it in the README? (both answers are OK to me, feels like an edge case)
Agree, also it could make the behavior unclear if I understand the alternative correctly. |
fa010b6 to
6749af1
Compare
|
@fflorent and I couldn't find where the usertypes' Conversion from text column is a good first step imo, we can look at using the env variables in ValueGuesser too but that's more work and should be a separate PR. |
|
The CI failure seems unrelated to my work |
It wasn't a lot of work to setup, if you trust the LLMs. It's probably correct here: localized_bools = {
'ar': {'true': ['نعم', 'صحيح', '1'], 'false': ['لا', 'خطأ', '0']},
'bg': {'true': ['да', 'вярно', '1'], 'false': ['не', 'невярно', '0']},
'ca': {'true': ['sí', 'cert', '1'], 'false': ['no', 'fals', '0']},
'cs': {'true': ['ano', 'pravda', '1'], 'false': ['ne', 'nepravda', '0']},
'de': {'true': ['ja', 'wahr', '1'], 'false': ['nein', 'falsch', '0']},
'el': {'true': ['ναι', 'σωστό', '1'], 'false': ['όχι', 'λάθος', '0']},
'en': {'true': ['yes', 'true', '1'], 'false': ['no', 'false', '0']},
'en_GB': {'true': ['yes', 'true', '1'], 'false': ['no', 'false', '0']},
'es': {'true': ['sí', 'verdadero', '1'], 'false': ['no', 'falso', '0']},
'eu': {'true': ['bai', 'egia', '1'], 'false': ['ez', 'gezurra', '0']},
'fa': {'true': ['بله', 'درست', '1'], 'false': ['نه', 'نادرست', '0']},
'fi': {'true': ['kyllä', 'tosi', '1'], 'false': ['ei', 'epätosi', '0']},
'fr': {'true': ['oui', 'vrai', '1'], 'false': ['non', 'faux', '0']},
'hu': {'true': ['igen', 'igaz', '1'], 'false': ['nem', 'hamis', '0']},
'ig': {'true': ['ee', 'ezigbo', '1'], 'false': ['mba', 'ụgha', '0']},
'it': {'true': ['sì', 'vero', '1'], 'false': ['no', 'falso', '0']},
'ja': {'true': ['はい', '真', '1'], 'false': ['いいえ', '偽', '0']},
'ko': {'true': ['예', '참', '1'], 'false': ['아니요', '거짓', '0']},
'nb_NO': {'true': ['ja', 'sant', '1'], 'false': ['nei', 'usant', '0']},
'nl': {'true': ['ja', 'waar', '1'], 'false': ['nee', 'onwaar', '0']},
'pl': {'true': ['tak', 'prawda', '1'], 'false': ['nie', 'fałsz', '0']},
'pt': {'true': ['sim', 'verdadeiro', '1'], 'false': ['não', 'falso', '0']},
'pt_BR': {'true': ['sim', 'verdadeiro', '1'], 'false': ['não', 'falso', '0']},
'ro': {'true': ['da', 'adevărat', '1'], 'false': ['nu', 'fals', '0']},
'ru': {'true': ['да', 'истина', '1'], 'false': ['нет', 'ложь', '0']},
'sk': {'true': ['áno', 'pravda', '1'], 'false': ['nie', 'nepravda', '0']},
'sl': {'true': ['da', 'resnica', '1'], 'false': ['ne', 'napačno', '0']},
'ta': {'true': ['ஆம்', 'உண்மை', '1'], 'false': ['இல்லை', 'தவறு', '0']},
'th': {'true': ['ใช่', 'จริง', '1'], 'false': ['ไม่', 'เท็จ', '0']},
'tr': {'true': ['evet', 'doğru', '1'], 'false': ['hayır', 'yanlış', '0']},
'uk': {'true': ['так', 'істина', '1'], 'false': ['ні', 'неправда', '0']},
'vi': {'true': ['đúng', 'có', '1'], 'false': ['sai', 'không', '0']},
'zh_Hans': {'true': ['是', '真', '1'], 'false': ['否', '假', '0']},
'zh_Hant': {'true': ['是', '真', '1'], 'false': ['否', '假', '0']},
} |
|
@vviers it looks good, would be nice to have a test. Looked through tests and closest is in it('sandbox passes in truthy/falsy settings', async function() {
const env = new EnvironmentSnapshot();
try {
process.env.GRIST_TRUTHY_VALUES = 'meep';
const activeDoc = new ActiveDoc(docTools.getDocManager(), 'truthyTest');
await activeDoc.createEmptyDoc(fakeSession);
await activeDoc.applyUserActions(fakeSession, [
["AddTable", "Info", [{id: 'Flag', type: 'Bool'}]],
["AddRecord", "Info", null, {Flag: 'meep'}],
["AddRecord", "Info", null, {Flag: 'moop'}],
]);
const data = (await activeDoc.fetchTable(fakeSession, 'Info', true)).tableData[3];
console.log(data); // shows { manualSort: [ 1, 2 ], Flag: [ true, 'moop' ] }
await activeDoc.shutdown();
} finally {
env.restore();
}
}); |
|
@paulfitz done ✅ thank you ! |
Context
This PR tries to solve the issue described in #1702 through the introduction of 2 env variables :
GRIST_TRUTHY_VALUESandGRIST_FALSY_VALUESProposed solution
I introduce 2 env variables that are passed to the python sandbox.
I know sandbox security is quite crucial, and so I'm looking for feedback as to whether that is safe.it is :)Related issues
Closes #1702
Has this been tested?