refactor: call the trait method instead of the instance method #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
First of all, thank you for this cool crate.
Recently I have worked on implementing support for the
borshcrate to make it possible to derive its traits usingnutype.While working on it, I encountered the error that it is impossible to derive both
serdeandborshtraits.This was because I used instance methods, and there was a conflict of
serializemethod implementations.I solved this using the original trait method, and now everything works fine.
This little change is supposed to avoid such problems in future features.
Also, this will improve code consistency because such an approach is already used in the
Deserializetrait implementation.