Skip to content
This repository was archived by the owner on Jan 30, 2025. It is now read-only.

Desobekify Viewport #1520

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Desobekify Viewport #1520

merged 6 commits into from
Nov 7, 2024

Conversation

inancgumus
Copy link
Collaborator

What?

  • Desobekify Viewport.
  • Turn Viewport into a value type.

Why?

See "Desobekifying Sobek transformation" at grafana/k6#4219.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

@inancgumus inancgumus self-assigned this Nov 6, 2024
@inancgumus inancgumus added stability runtime stability improvements refactor labels Nov 6, 2024
@inancgumus inancgumus changed the base branch from main to desobekify/screen November 6, 2024 20:14
@inancgumus inancgumus marked this pull request as ready for review November 6, 2024 20:23
@inancgumus inancgumus requested a review from ankur22 November 6, 2024 20:23
@inancgumus inancgumus mentioned this pull request Nov 6, 2024
Closed
ankur22
ankur22 previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inancgumus inancgumus requested a review from a team as a code owner November 7, 2024 14:43
@inancgumus inancgumus requested review from olegbespalov and oleiade and removed request for a team November 7, 2024 14:43
Base automatically changed from desobekify/screen to main November 7, 2024 14:43
@inancgumus inancgumus dismissed ankur22’s stale review November 7, 2024 14:43

The base branch was changed.

@inancgumus inancgumus merged commit 7c9f9c1 into main Nov 7, 2024
5 checks passed
@inancgumus inancgumus deleted the desobekify/viewport branch November 7, 2024 14:44
@BrewTestBot BrewTestBot mentioned this pull request Jan 6, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers