This repository was archived by the owner on Jan 30, 2025. It is now read-only.
Refactor parsing of options for waitForEvent #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves the option parsing out of the promise for browserContext.waitForEvent. The change will help mitigate the risk of accessing the (non thread safe) goja runtime by multiple goroutines and instead force the parse (and working with the goja runtime) in the main goja thread.
ka3de
reviewed
Jan 24, 2024
ka3de
approved these changes
Jan 24, 2024
inancgumus
approved these changes
Jan 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor the parsing of the options for the
browserContext.waitForEventAPI so that it is done outside the promise and therefore on the main goja thread.Why?
This will help mitigate issues which can occur when trying to access the goja runtime from multiple goroutines, which can causes panics since the goja runtime is not thread safe.
Checklist
Related PR(s)/Issue(s)
Updates: #1187