This repository was archived by the owner on Jan 30, 2025. It is now read-only.
Fix concurrent usage of goja.Runtime in waitForNavigation #508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a functional change from before, since the iteration won't be interrupted by a timeout error anymore, and the promise will be rejected instead. This might be an acceptable tradeoff for using a lock, but it would be better if there was a way of interrupting the iteration if the promise is rejected. Fixes #506
I do think the decision on whether the iteration should be interrupted should be of the user writing the test. They can do that through just on an exception/failure on this promise - abort the iteration :). But IMO there are good reason for this to not be hardcoded like actually maybe retrying or doing other stuff when this fails. Maybe they need to free some resources 🤷 . So as far as I am concerned this is a double bugfix :P |
mstoykov
reviewed
Aug 18, 2022
ankur22
reviewed
Aug 18, 2022
ankur22
approved these changes
Aug 18, 2022
mstoykov
approved these changes
Aug 18, 2022
|
I'm not sure if the current failure of #509 is related to these changes or not... 😕 I've only seen it in tests so far, and we need to fix this issue, so I'll merge this and we can look into that later if it becomes a bigger problem. |
imiric
pushed a commit
that referenced
this pull request
Sep 2, 2022
imiric
pushed a commit
that referenced
this pull request
Sep 2, 2022
Merged
ankur22
pushed a commit
that referenced
this pull request
Sep 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a functional change from before, since the iteration won't be interrupted by a timeout error anymore, and the promise will be rejected instead. This might be an acceptable tradeoff for using a lock, but it would be better if there was a way of interrupting the iteration if the promise is rejected.
Fixes #506