feat: Implement artificial ingestion delay. #4251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
215388a to
6cb7d77
Compare
kolesnikovae
approved these changes
Jun 16, 2025
Collaborator
kolesnikovae
left a comment
There was a problem hiding this comment.
LGTM
Thanks for adding this!
pkg/util/delayhandler/http.go
Outdated
Comment on lines
64
to
77
| func NewHTTP(limits Limits) func(h http.Handler) http.Handler { | ||
| return func(h http.Handler) http.Handler { | ||
| return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| start := timeNow() | ||
| ctx := r.Context() | ||
|
|
||
| delay := getDelay(ctx, limits) | ||
| var delayRw *delayedResponseWriter | ||
| if delay > 0 { | ||
| w, delayRw = wrapResponseWriter(w, start.Add(delay)) | ||
| } | ||
|
|
||
| // now run the chain after me | ||
| h.ServeHTTP(w, r.WithContext(ctx)) |
Collaborator
There was a problem hiding this comment.
I'm not sure why we replace the request context. If we haven't modified it, it should not be needed
Contributor
Author
There was a problem hiding this comment.
Good spotted, I had a trace span created in some previous version
This implements the ability to add artificial delay to the ingestion handlers. This is useful during the v2 migration process in order to spot how client will behave Fixes grafana/pyroscope-squad#454
f11b7e4 to
bd040b5
Compare
simonswine
added a commit
that referenced
this pull request
Jun 16, 2025
* feat: Add artificial ingestion delay This implements the ability to add artificial delay to the ingestion handlers. This is useful during the v2 migration process in order to spot how client will behave Fixes grafana/pyroscope-squad#454 * Remove unnecessary ctx variable * Use unimplemented embedding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the ability to add artificial delay to the ingestion handlers.
This is useful during the v2 migration process in order to spot how client will behave
Inspired by Mimir implementation:
artificialDelayonServerTimingheader for push requests mimir#11265This relies on #4249
Once this is enabled, we also need to update dashboards to show the metrics without artificial delay