chore: Move the validation func from helpers to ramping vus #3616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3616 +/- ##
=======================================
Coverage 73.57% 73.58%
=======================================
Files 277 277
Lines 20244 20244
=======================================
+ Hits 14895 14896 +1
+ Misses 4401 4400 -1
Partials 948 948
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b0da697 to
37573c8
Compare
37573c8 to
3753ec6
Compare
joanlopez
approved these changes
Oct 9, 2025
mstoykov
approved these changes
Oct 9, 2025
rMaxiQp
pushed a commit
to rMaxiQp/k6
that referenced
this pull request
Oct 9, 2025
…3616) Moved the validation function to the ramping vus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I had it on a draft for a long time and I think is still worth considering the low effort. It amends what we did on #3470 moving the function closer to where they are used.
Why?
The logic implemented is specific for ramping-vus and it shouldn't be reusable for other executors. Then it's better to have it in the specific file instead of the generic
helpers.