Skip to content

Conversation

codebien
Copy link
Contributor

What?

Why?

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

@codebien codebien self-assigned this Sep 25, 2025
@codebien codebien temporarily deployed to azure-trusted-signing September 25, 2025 08:55 — with GitHub Actions Inactive
@codebien codebien temporarily deployed to azure-trusted-signing September 25, 2025 08:56 — with GitHub Actions Inactive
Comment on lines 19 to 21
"enabled": true,
"ignoreDeps": ["indirect"],
"postUpdateOptions": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"enabled": true,
"ignoreDeps": ["indirect"],
"postUpdateOptions": [
"enabled": true,
"ignoreDeps": ["indirect"],
"postUpdateOptions": [

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not yet fully sure this is really needed. I suspect there is an issue on xk6-dashboard and this is the reason why we're seeing the update here.

So I'd like to be sure that this line is really needed, because by default this shouldn't happen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm waiting for Renovate to trigger on xk6-dashboard.

Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can we merge it :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants