Unify unauthenticated errors for Cloud commands #5117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
984c814 to
d6a8512
Compare
d6a8512 to
bc3f664
Compare
joanlopez
reviewed
Sep 1, 2025
internal/cmd/cloud.go
Outdated
| "github.com/spf13/pflag" | ||
| ) | ||
|
|
||
| // ErrUserUnauthenticated represents an authentication error when trying to use |
There was a problem hiding this comment.
Do we really need to make this error public? 🤔 I'm wondering because I see it's used by no other package, and it's internal so other projects like extensions could not use it.
There was a problem hiding this comment.
No, we don't. I've changed it, good catch!
joanlopez
reviewed
Sep 1, 2025
joanlopez
reviewed
Sep 1, 2025
joanlopez
reviewed
Sep 1, 2025
Co-authored-by: Joan López de la Franca Beltran <[email protected]>
joanlopez
approved these changes
Sep 1, 2025
mstoykov
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If the user is not logged in or didn't provide any TOKEN option via the available methods then it will fail with a nicer error hinting how to fix it.
If the token is provided but it is not valid then the error it is still delegated to the Cloud.
Why?
If the user forgot to log in or didn't know about the requirement now it is easier to understand and fix it.
Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Closes #5077