Fix exec context adoption #5084
Conversation
Having looked at how Playwright works through adoption, I've realised that it only adopts when the handle is from the current frame, and when the handle is in the utility exec context. I've made the change to ensure that adoption only occurs when the handle is part of the current frame's utility exec context.
11db555 to
cd3805b
Compare
There was a problem hiding this comment.
Adoption only works when adopting between mainWorld and utilityWorld from within the same frame. Each frame has these two execution contexts. We cannot adopt elements/handles from one frame to another, and there should be no reason to do so.
@ankur22 If I understand correctly, before it was allowed to mix elements and frames which is not the case anymore with the new change. We should guard this logic with a unit test. Can you add a one, please?
I'd love to be able to unit test this, but I think it would require a lot of refactoring. The changes in another PR (#5075) require the fix in this PR, and there is an integration test which will fail due to any regression. |
What?
Having looked at how Playwright works through adoption, I've realised that it only adopts when:
utilityWorld.I've made the change to ensure that adoption only occurs when the handle is part of the current frame's
utilityWorldexec context.Why?
While working on #5032, the current implementation is causing an issue whereby it is trying to adopt a handle from a nested frame to the page's frame (different origin), which isn't possible and is preventing APIs from working when using
locatorsiniframes.Adoption only works when adopting between
mainWorldandutilityWorldfrom within the same frame. Each frame has these two execution contexts. We cannot adopt elements/handles from one frame to another, and there should be no reason to do so.Checklist
make check) and all pass.Checklist: Documentation (only for k6 maintainers and if relevant)
Please do not merge this PR until the following items are filled out.
Related PR(s)/Issue(s)
Linked to, but doesn't close: #5085