Skip to content

Fix namespaced object export when default is the only one available #4058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 15, 2024
Merged

Fix namespaced object export when default is the only one available #4058

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
68a2440
Refactor to a switch
ankur22 Nov 14, 2024
efb0611
Add conversion from default to namspaced object
ankur22 Nov 14, 2024
ac530c6
Update test to handle default to namespaced object
ankur22 Nov 14, 2024
241af93
Update to work with nil check over len
ankur22 Nov 14, 2024
134399b
Fix slice make
ankur22 Nov 14, 2024
296f8c2
Update to work with ToObject instead of cast
ankur22 Nov 14, 2024
502376b
Refactor test into a sub test
ankur22 Nov 14, 2024
b301b49
Remove non ESM import from test
ankur22 Nov 14, 2024
f492b40
Add a test to compare object and namespaced obj
ankur22 Nov 14, 2024
37a78c6
Refactor back to if/else instead of switch
ankur22 Nov 15, 2024
636484f
Update comment
ankur22 Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix slice make 
It needs to be of length 0 to allow for append from 0.
  • Loading branch information
@ankur22
ankur22 committed Nov 14, 2024
commit 134399b4273ecd631c6fa41bc0a91cec1623c827
2 changes: 1 addition & 1 deletion js/modules/gomodule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func (gm *goModule) Instantiate(rt *sobek.Runtime) (sobek.CyclicModuleInstance,
gm.exportedNames = obj.GetOwnPropertyNames()
}
default:
gm.exportedNames = make([]string, len(named))
gm.exportedNames = make([]string, 0, len(named))
for name := range named {
gm.exportedNames = append(gm.exportedNames, name)
}
Expand Down