Skip to content

Default plugin ID to the name of the declaration #36065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
urdak wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Default plugin ID to the name of the declaration #36065

urdak wants to merge 1 commit into from
+13 −9

Conversation

@urdak
Copy link
Contributor

@urdak urdak commented Dec 18, 2025

Removes redundancy when registering plugins

Fixes #35649

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@urdak
Default plugin ID to the name of the declaration
6850b5f 
Removes redundancy when registering plugins

Signed-off-by: Victor Merkulov <[email protected]>
@urdak urdak requested a review from a team as a code owner December 18, 2025 00:59
@urdak urdak requested a review from jbartok December 18, 2025 00:59
@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Dec 18, 2025
urdak
urdak commented Dec 18, 2025
View reviewed changes
...xtensibility/plugin-development/src/main/java/org/gradle/plugin/devel/PluginDeclaration.java
*/
@ToBeReplacedByLazyProperty
@NonNull
public String getId() {
Copy link
Contributor Author

@urdak urdak Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to also migrate to the lazy property API in this PR?

Copy link
Contributor

@hfhbd hfhbd Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be a breaking change. IMHO the id should be deprecated in Gradle 9 and removed in Gradle 10, I never understood the use-case of name and id.

@ljacomet
Copy link
Member

ljacomet commented Dec 18, 2025

Thank you for your proposed contribution!

This PR has a valid DCO and tests. The relevant team for this area will confirm the design of the implementation choices.

@ljacomet ljacomet added in:plugin-development 👋 team-triage Issues that need to be triaged by a specific team and removed to-triage labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbartok jbartok Awaiting requested review from jbartok jbartok is a code owner automatically assigned from gradle/bt-tide

1 more reviewer

@hfhbd hfhbd hfhbd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

from:contributor PR by an external contributor in:plugin-development 👋 team-triage Issues that need to be triaged by a specific team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default plugin id to the name of registration container

4 participants

@urdak @ljacomet @hfhbd @bot-gradle