Skip to content

Conversation

hfhbd
Copy link
Contributor

@hfhbd hfhbd commented Oct 7, 2025

Follow-up of #35068

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@hfhbd hfhbd requested review from a team as code owners October 7, 2025 19:35
@hfhbd hfhbd requested review from octylFractal and jbartok October 7, 2025 19:35
@bot-gradle bot-gradle added the from:contributor PR by an external contributor label Oct 7, 2025
@hfhbd hfhbd requested review from alllex and 6hundreds and removed request for a team October 7, 2025 19:35
@hfhbd hfhbd force-pushed the attribute-container-kts branch from 50f883a to 06ca81c Compare October 7, 2025 20:10
@alllex alllex removed their request for review October 8, 2025 09:05
@hegyibalint hegyibalint added in:dependency-declarations variant notation attributes capability substitution 👋 team-triage Issues that need to be triaged by a specific team and removed to-triage labels Oct 9, 2025
@hegyibalint
Copy link
Member

Thank you for your proposed contribution!

This PR has a valid DCO and tests. The relevant team for this area will confirm the design of the implementation choices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:contributor PR by an external contributor in:dependency-declarations variant notation attributes capability substitution 👋 team-triage Issues that need to be triaged by a specific team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants