Skip to content

Conversation

SimonMarquis
Copy link
Contributor

Context

https://docs.gradle.org/current/userguide/best_practices_dependencies.html#dont_do_this

The Kotlin code snippet was using an extra/unnecessary dependencies call that the Groovy code snippet does not have, and is irrelevant to the tip.

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

@SimonMarquis SimonMarquis requested a review from a team as a code owner September 6, 2025 07:50
@bot-gradle bot-gradle added from:contributor PR by an external contributor to-triage labels Sep 6, 2025
@lkasso lkasso added a:documentation Documentation content re:footguns-and-best-practices Issues related to avoiding pitfalls in Gradle and removed to-triage labels Sep 7, 2025
@lkasso lkasso added this pull request to the merge queue Sep 7, 2025
@bot-gradle bot-gradle added this to the 9.2.0 RC1 milestone Sep 7, 2025
Merged via the queue into gradle:master with commit ed62fcb Sep 7, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:documentation Documentation content from:contributor PR by an external contributor re:footguns-and-best-practices Issues related to avoiding pitfalls in Gradle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants