Skip to content

Conversation

sorin-florea
Copy link
Member

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@sorin-florea sorin-florea requested review from a team as code owners July 15, 2025 13:47
@sorin-florea sorin-florea requested a review from a team July 15, 2025 13:47
@sorin-florea

This comment has been minimized.

@bot-gradle

This comment has been minimized.

@sorin-florea

This comment has been minimized.

@bot-gradle bot-gradle added this pull request to the merge queue Jul 15, 2025
@bot-gradle bot-gradle added this to the 9.1.0 RC1 milestone Jul 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 15, 2025
@cobexer
Copy link
Member

cobexer commented Jul 15, 2025

@sorin-florea PTAL at the merge failure

…city-plugin-4.1

* origin/master:
  Fix distro test
  Publish 9.0.0-20250715101636+0000
  Remove extra blank line
  Workaround issue with Develocity by only looking at failures associated with a test worker
  Capture unwanted interaction between Develocity and test executors
  Rename smoke tests for Develocity plugin to say Develocity
  Improve distro size check: relax conditions for promotion builds
@sorin-florea
Copy link
Member Author

@bot-gradle test and merge

@bot-gradle bot-gradle enabled auto-merge July 15, 2025 14:21
@bot-gradle bot-gradle added this pull request to the merge queue Jul 15, 2025
@bot-gradle
Copy link
Collaborator

The following builds have passed:

Merged via the queue into master with commit 46415e9 Jul 15, 2025
26 checks passed
@bot-gradle bot-gradle deleted the sorin/update-develocity-plugin-4.1 branch July 15, 2025 15:51
@wolfs
Copy link
Member

wolfs commented Jul 16, 2025

@bot-gradle cherry-pick to release

@bot-gradle
Copy link
Collaborator

I have cherry-picked to PR #34278.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants