Introduce execution time value for SubtractingFileCollection
#32801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bot-gradle test this on linux |
This comment has been minimized.
This comment has been minimized.
SubtractingFileCollectionSubtractingFileCollection
5 tasks
|
The following builds have failed: |
5ae9170 to
9422657
Compare
alllex
approved these changes
Mar 21, 2025
|
|
||
| import static org.gradle.api.internal.file.TestFiles.fileCollectionFactory | ||
|
|
||
| class SubtractingFileCollectionExecutionTimeValueTest extends Specification { |
There was a problem hiding this comment.
💅 The test class seems to be more about the SubtractingFileCollection. Testing execution time value behavior is only one aspect. I'd rename the test class to accommodate for future unit tests for the collection itself.
There was a problem hiding this comment.
We have a bunch of tests similarly named like this (by me). They are targeting only ETV intentionally, since further ETV implementations will not so simple, and perhaps will require more extensive coverage.
|
WARN: The milestone of this PR is 8.14 RC1, but the base branch version is 9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #28820