Skip to content

[Spike] Use Unix domain sockets in FileLockCommunicator #31856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[Spike] Use Unix domain sockets in FileLockCommunicator #31856

wants to merge 6 commits into from

Conversation

asodja
Copy link
Member

@asodja asodja commented Dec 20, 2024

Relates to #31394

@asodja asodja self-assigned this Dec 20, 2024
@asodja asodja added a:feature A new functionality in:daemon labels Dec 20, 2024
@asodja asodja force-pushed the asodja/unix-domain-sockets branch from b330a46 to 0a3f978 Compare December 20, 2024 15:26
octylFractal
octylFractal reviewed Dec 20, 2024
View reviewed changes
...c/main/java/org/gradle/cache/internal/locklistener/UnixDomainSocketFileLockCommunicator.java
Comment on lines +176 to +181
// TODO: Where to put domain sockets? If we put them in gradleUserHomeDir, we can get
// java.net.SocketException: Unix domain path too long
File unixDomainSocketsDir = new File("/tmp/gradle");
Copy link
Member

@octylFractal octylFractal Dec 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure where macOS expects them, but the Linux standard is to put these things in $XDG_RUNTIME_DIR or failing that $TMPDIR.

Looking at https://github.com/dirs-dev/directories-jvm/blob/main/src/main/java/dev/dirs/ProjectDirectories.java#L237, it seems like there's no equivalent directory for macOS/Windows.

So I think using $XDG_RUNTIME_DIR/gradle on Linux if possible, and using the actual temporary directory ${java.io.tmpdir}/gradle otherwise, would be the best option.