Allow public API to declare Problem IDs in a unified way #31778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
reinsch82
reviewed
Dec 16, 2024
| * @return the instance | ||
| * @since 8.13 | ||
| */ | ||
| public static IdFactory instance() { |
There was a problem hiding this comment.
That's the interesting bit in the review. My stance is that problem Ids and groups are lightweight descriptors that Gradle and third party plugins both should be able to define as static data. ie:
class MyProblemIds {
public static final ProblemGroup group = ...
public static final ProblemId id1 = ...
public static final ProblemId id2 = ...
}
I played around with making it a service but it made the the whole Problems API usage a fair bit clunky to use.
...s/ide/problems-api/src/main/java/org/gradle/api/problems/internal/DefaultProblemBuilder.java
Show resolved
Hide resolved
...onTest/groovy/org/gradle/integtests/tooling/r812/ProblemProgressEventCrossVersionTest.groovy
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
641b659 to
149def4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
149def4 to
d0dfd7e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
d0dfd7e to
28ced5e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
28ced5e to
ef3c29e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The following builds have failed: |
|
The following builds have failed: |
ef3c29e to
60279d3
Compare
|
@bot-gradle merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to review changes at #31674 in reviewable steps.
Reviewing cheatsheet
Before merging the PR, comments starting with