Skip to content

Conversation

lkasso
Copy link
Member

@lkasso lkasso commented Oct 22, 2024

Context

Contributor Checklist

  • Review Contribution Guidelines.
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team.
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective.
  • Provide unit tests (under <subproject>/src/test) to verify logic.
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes.
  • Ensure that tests pass sanity check: ./gradlew sanityCheck.
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@lkasso lkasso added the a:documentation Documentation content label Oct 22, 2024
@lkasso lkasso requested review from a team as code owners October 22, 2024 05:24
@lkasso lkasso requested a review from ghale October 22, 2024 05:24
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. If you don't want the stale bot to close it, then set a milestone for it.

@github-actions github-actions bot added the stale label Nov 21, 2024
@github-actions github-actions bot removed the stale label Nov 25, 2024
@lkasso lkasso added this to the 8.12 RC1 milestone Dec 2, 2024
@lkasso lkasso added this pull request to the merge queue Dec 2, 2024
@lkasso lkasso added the in:java-plugins java-library, java, java-base, java-platform, java-test-fixtures label Dec 2, 2024
Merged via the queue into master with commit efb4ab2 Dec 2, 2024
23 checks passed
@lkasso lkasso deleted the lkasso/documentation/annotationprocessor-doc branch December 2, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:documentation Documentation content in:java-plugins java-library, java, java-base, java-platform, java-test-fixtures

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants