Deprecation warning for task.getProject() should not be conditional on STABLE_CONFIGURATION_CACHE #30886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f97f59a to
68c7d02
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
859c489 to
4f3b8c0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4f3b8c0 to
a1198d5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- Expect deprecation for Task.project in Nebula dependency lock and lint plugins - Expect `Task.project` deprecation in gradle-versions-plugin - Expect `Task.project` deprecation in Gretty - Expect `Task.project` deprecation for older version of Asciidoctor plugin - Expect deprecation for Task.project in KMP
...which use `dependentComponents`, `model`, `component` tasks
...otherwise, executer needs to be reconfigured every time. This is useful for setup that needs to be done the same way no matter how may times executer is invoked from all test cases in a test class.
…esting-native` tests
…model-core` tests
This reverts commit 3b0e83f.
e5e4171 to
ca2762f
Compare
|
@bot-gradle test RFN |
This comment has been minimized.
This comment has been minimized.
|
The following builds have failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #30860
platforms/core-configuration/configuration-cache/src/main/kotlin/org/gradle/internal/cc/impl/DeprecatedFeaturesListener.ktso Task.project deprecations are no longer behindSTABLE_CONFIGURATION_CACHEtesting/internal-integ-testing/src/main/groovy/org/gradle/integtests/fixtures/CommonDeprecations.groovytrait to be applied to tests that may need to expect the deprecationplatforms/documentation/docs/src/docs/userguide/optimizing-performance/configuration_cache.adocso the deprecation is no longer linked to the feature flagplatforms/native/language-native/src/main/java/org/gradle/swiftpm/tasks/GenerateSwiftPackageManagerManifest.javaso it no longer accessesTask.projectat execution time (all it needeed was the project name), and updated corresponding tests to remove@ToBeFixedForCC)platforms/software/dependency-management/src/integTest/groovy/org/gradle/integtests/resolve/UnsafeConfigurationResolutionDeprecationIntegrationTest.groovy)To be done:
Reviewing cheatsheet
Before merging the PR, comments starting with