Use Jackson for json serialization for problem reports and CC reports #30380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a9fd77 to
22fb12a
Compare
22fb12a to
5beda6c
Compare
donat
approved these changes
Sep 3, 2024
|
WARN: Based on labels, this pull request addresses notable issue but no changes to release note found. |
bamboo
reviewed
Sep 3, 2024
| val toString = StringWriter().also { | ||
| val jsonWriter = JsonWriter(it) | ||
| jsonWriter.apply(builder) | ||
| jsonWriter.flush() |
There was a problem hiding this comment.
💭 Making it an AutoCloseable resource would probably help here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/gradle/gradle-private/issues/4448
Reviewing cheatsheet
Before merging the PR, comments starting with