Let generated Kotlin extensions for the Gradle API be properly annotated with @Incubating and @since
#27025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uction code instead of code from the wrapper by isolating the execution in a tailored classloader via a JDK only facade
when the extended type itself is `@Incubating`
by specifying explicit return types where ambiguous
by removing unnecessary type parameter by fixing java.lang.annotation.Annotation package name in mapped type strings
by using URLClassloader instead of VisitableURLClassLoader
by parsing java sources to get the javadoc tag value
by fixing indentation to make ktlint happy
|
@bot-gradle merge |
|
Your PR is queued. See the queue page for details. |
meowool-bot
added a commit
to meowool/cradle
that referenced
this pull request
Nov 14, 2023
This commit synchronizes the latest 9 changes from the https://github.com/gradle/gradle/tree/master. The changes include: e4b8411: gradle/gradle#27025 Let generated Kotlin extensions for the Gradle API be properly annotated with `@Incubating` and `@since` f887f85: Polish ApiExtensionsGenerator 8a34f3f: Add `@since` to generated Kotlin extensions 791e380: Upgrade qdox from 2.0.0 to 2.0.3 in build-logic/ afe4fef: Polish KotlinExtensionsForGradleApiFacade 3160d53: Polish ApiTypeProvider 8c88929: Polish ApiExtensionsGenerator 9768a05: Let Gradle API Kotlin extension files be annotated `@Incubating` 4ae3f54: Rework GenerateKotlinExtensionsForGradleApi task to actually use production code instead of code from the wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some classloading gymnastic involved in order for the
build-logic/tasks to use the right version ofgradle-kotlin-dsl-shared-runtimewithout requiring a wrapper update and to isolate source code parsing for@sincetags fromgradle-kotlin-dsl-shared-runtime.