Skip to content

Conversation

hwanseok-dev
Copy link

Page "part4_gradle_plugins.html" section "step_3_add_the_publishing_block" has a deprecated keyword "create("maven")". It does not work at gradle 8.2. Replace "create("maven")" to "mavenJava(MavenPublication)" according to gradle 8.2 docs

Context

Contributor Checklist

  • Review Contribution Guidelines
  • Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
  • Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
  • Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
  • Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
  • Provide unit tests (under <subproject>/src/test) to verify logic
  • Update User Guide, DSL Reference, and Javadoc for public-facing changes
  • Ensure that tests pass sanity check: ./gradlew sanityCheck
  • Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@hwanseok-dev hwanseok-dev requested a review from a team as a code owner August 21, 2023 03:02
@bot-gradle bot-gradle added the from:contributor PR by an external contributor label Aug 21, 2023
@lkasso lkasso added the a:documentation Documentation content label Aug 21, 2023
@lkasso
Copy link
Member

lkasso commented Aug 21, 2023

@hwanseok-dev, can you fix the DCO by including this in your commit: Signed-off-by: Author Name <[email protected]> . You can also do this automatically by using the -s flag (i.e., git commit -s).

Then I can go ahead and merge to master.

Page "part4_gradle_plugins.html" section "step_3_add_the_publishing_block" has a deprecated keyword "create<MavenPublication>("maven")". It does not work at gradle 8.2.
Replace "create<MavenPublication>("maven")" to "mavenJava(MavenPublication)" according to gradle 8.2 docs

- getting started docs : https://docs.gradle.org/current/userguide/part4_gradle_plugins.html#step_3_add_the_publishing_block
- maven publish plugins docs : https://docs.gradle.org/current/userguide/publishing_maven.html#sec:modifying_the_generated_pom

Signed-off-by: HwanSeok Jang <[email protected]>
@hwanseok-dev hwanseok-dev force-pushed the feature/docs-gradle-deprecated-keyword branch from 0bfedc5 to 65a851a Compare August 21, 2023 23:23
@hwanseok-dev
Copy link
Author

I'll PR again with another github account

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels