-
Notifications
You must be signed in to change notification settings - Fork 5k
docs: Fix Deprecated keyword in getting started #26148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
hwanseok-dev
wants to merge
1
commit into
gradle:master
from
hwanseok-dev:feature/docs-gradle-deprecated-keyword
Closed
docs: Fix Deprecated keyword in getting started #26148
hwanseok-dev
wants to merge
1
commit into
gradle:master
from
hwanseok-dev:feature/docs-gradle-deprecated-keyword
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkasso
approved these changes
Aug 21, 2023
@hwanseok-dev, can you fix the DCO by including this in your commit: Then I can go ahead and merge to master. |
Page "part4_gradle_plugins.html" section "step_3_add_the_publishing_block" has a deprecated keyword "create<MavenPublication>("maven")". It does not work at gradle 8.2. Replace "create<MavenPublication>("maven")" to "mavenJava(MavenPublication)" according to gradle 8.2 docs - getting started docs : https://docs.gradle.org/current/userguide/part4_gradle_plugins.html#step_3_add_the_publishing_block - maven publish plugins docs : https://docs.gradle.org/current/userguide/publishing_maven.html#sec:modifying_the_generated_pom Signed-off-by: HwanSeok Jang <[email protected]>
0bfedc5
to
65a851a
Compare
I'll PR again with another github account |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Page "part4_gradle_plugins.html" section "step_3_add_the_publishing_block" has a deprecated keyword "create("maven")". It does not work at gradle 8.2. Replace "create("maven")" to "mavenJava(MavenPublication)" according to gradle 8.2 docs
Context
Contributor Checklist
<subproject>/src/integTest
) to verify changes from a user perspective<subproject>/src/test
) to verify logic./gradlew sanityCheck
./gradlew <changed-subproject>:quickTest
Reviewing cheatsheet
Before merging the PR, comments starting with