Skip to content

Remove usage of Java14HomeAvailable requirement #26033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2023
Merged

Remove usage of Java14HomeAvailable requirement #26033

merged 1 commit into from
Aug 7, 2023

Conversation

wolfs
Copy link
Member

@wolfs wolfs commented Aug 7, 2023

We don't have Java 14 installed on any of our CI agents.

@wolfs
Remove usage of Java14HomeAvailable requirement
702f8b0 
We don't have Java 14 installed on any of our CI agents.
@wolfs wolfs added this to the 8.4 RC1 milestone Aug 7, 2023
@wolfs wolfs self-assigned this Aug 7, 2023
@wolfs wolfs requested review from a team as code owners August 7, 2023 06:58
@wolfs wolfs requested a review from octylFractal August 7, 2023 06:58
@gitstream-cm
Copy link

gitstream-cm bot commented Aug 7, 2023

🥷 Code experts: octylFractal

octylFractal, wolfs have most 👩‍💻 activity in the files.
wolfs has most 🧠 knowledge in the files.

See details

subprojects/internal-integ-testing/src/main/groovy/org/gradle/test/preconditions/IntegTestPreconditions.groovy

Activity based on git-commit:

octylFractal wolfs
AUG
JUL
JUN
MAY 38 additions & 14 deletions
APR
MAR

Knowledge based on git-blame:
wolfs: 12%

subprojects/internal-testing/src/main/resources/valid-precondition-combinations.csv

Activity based on git-commit:

octylFractal wolfs
AUG
JUL 1 additions & 0 deletions
JUN
MAY 23 additions & 4 deletions
APR
MAR

Knowledge based on git-blame:
wolfs: 21%

subprojects/plugins/src/integTest/groovy/org/gradle/java/compile/BasicJavaCompilerIntegrationSpec.groovy

Activity based on git-commit:

octylFractal wolfs
AUG
JUL 62 additions & 60 deletions
JUN
MAY
APR
MAR

Knowledge based on git-blame:
wolfs: 3%

To learn more about /:\ gitStream - Visit our Docs

@gitstream-cm
Copy link

gitstream-cm bot commented Aug 7, 2023

This PR is 70.83% new code.
There are 17 added lines and 7 deleted lines.

blindpirate
blindpirate approved these changes Aug 7, 2023
View reviewed changes
Copy link
Collaborator

@blindpirate blindpirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wolfs
Copy link
Member Author

wolfs commented Aug 7, 2023

@bot-gradle test and merge

@bot-gradle
Copy link
Collaborator

Your PR is queued. See the queue page for details.

@bot-gradle
Copy link
Collaborator

I've triggered a build for you. Click here to see all failures if there's any.

@bot-gradle bot-gradle merged commit baa0e00 into master Aug 7, 2023
@bot-gradle bot-gradle deleted the wolfs/precondition/remove-java-14 branch August 7, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blindpirate blindpirate blindpirate approved these changes

@octylFractal octylFractal Awaiting requested review from octylFractal octylFractal was automatically assigned from gradle/bt-jvm

Assignees

@wolfs wolfs

Labels

None yet

Projects

None yet

Milestone

8.4 RC1

Development

Successfully merging this pull request may close these issues.

3 participants

@wolfs @bot-gradle @blindpirate