Skip to content

Remove Groovy Closure taking methods from public API #22349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 40 commits into
base: master
Choose a base branch
from
Draft

Remove Groovy Closure taking methods from public API #22349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
a96fc12
Remove Closure taking methods from Reporting
big-guy Sep 24, 2022
06f42e5
Remove Closure taking query methods from DomainObjectCollections
big-guy Sep 24, 2022
3af09e8
Remove create(String, Closure) from domain object collections
big-guy Sep 24, 2022
213e39d
Remove most of the Closure taking methods from Task
big-guy Sep 24, 2022
9774ff1
Add Action taking equivalents for all Closure-taking methods in Script
big-guy Sep 24, 2022
76f0977
Remove Closure taking methods from Script
big-guy Sep 24, 2022
9bae576
Linkify types in Task javadoc
big-guy Sep 24, 2022
6997035
Remove Closure taking methods from ComponentSelectionRules
big-guy Sep 24, 2022
ec11839
Remove Closure from ModuleDependency
big-guy Sep 24, 2022
0479d4e
Remove Closure taking methods from Configuration
big-guy Sep 24, 2022
ff87683
Remove Closure-taking methods from ArtifactHandler
big-guy Sep 24, 2022
8dabaa9
Remove Closure from ComponentMetadataHandler
big-guy Sep 24, 2022
4fc0614
Remove Closure taking methods from RepositoryHandler
big-guy Sep 24, 2022
a9ac555
Add Configurable.configure(Action)
big-guy Sep 24, 2022
ad90633
Remove most of the Closure-taking methods in Project
big-guy Sep 24, 2022
fbac41c
Add missing Action-taking methods for Project
big-guy Sep 24, 2022
e343a51
Remove Closure methods from PluginAware
big-guy Sep 24, 2022
6ffcc30
Remove the rest of the Closure taking methods from Project
big-guy Sep 24, 2022
1b01fc0
Remove explicit reference to configure(Closure) in NamedDomainObjectC…
big-guy Sep 24, 2022
5793488
Remove Closure methods from TaskExecutionGraph
big-guy Sep 24, 2022
d7baaf7
Remove Closure taking methods from file manipulating classes
big-guy Sep 24, 2022
75d472f
Remove Closure taking methods from Gradle
big-guy Sep 24, 2022
f225fc3
Remove Closure methods from PluginCollection
big-guy Sep 24, 2022
8ea3493
Remove Closure taking methods from TaskOutputs
big-guy Sep 24, 2022
01bbac2
Remove Closure methods from ProjectConfigurationActionContainer
big-guy Sep 24, 2022
e2d5dad
Remove Closure methods from Ear
big-guy Sep 24, 2022
af9cbaf
Remove Closure methods from Javadoc
big-guy Sep 24, 2022
b1c27c4
Remove some Closure taking methods from Test tasks
big-guy Sep 24, 2022
f60ea71
Remove Closure from SourceSet
big-guy Sep 24, 2022
33b62c9
Make sanityCheck happy
big-guy Sep 25, 2022
9335513
Fix javadoc generation
big-guy Sep 25, 2022
6c91e73
Update archunit baseline input
big-guy Sep 25, 2022
6021c8b
Revert "Remove the rest of the Closure taking methods from Project"
big-guy Sep 25, 2022
75f3031
Revert "Add missing Action-taking methods for Project"
big-guy Sep 25, 2022
51b8016
Make ktlint happy
big-guy Sep 25, 2022
5bc02cc
Ignore compatibility checks so we can run some tests
big-guy Sep 25, 2022
4202461
Remove Closure methods from DeploymentDescriptor
big-guy Sep 25, 2022
6665e09
Remove Closure from IDE related types
big-guy Sep 25, 2022
bc50fbf
Remove Closure methods from Jar and War
big-guy Sep 25, 2022
8164504
Add test for Closure-taking methods with CompileStatic
big-guy Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build-logic/binary-compatibility/src/main/groovy/gradlebuild.binary-compatibility.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ dependencies {
}

def checkBinaryCompatibility = tasks.register("checkBinaryCompatibility", JapicmpTask) {
enabled = false
def baseVersion = moduleIdentity.version.map { it.baseVersion.version }
def isSnapshot = moduleIdentity.snapshot
inputs.property('acceptedViolations', acceptedViolations.toAcceptedChangesMap())
Expand Down
36 changes: 18 additions & 18 deletions ...rojects/architecture-test/src/changes/archunit_store/3c3e47be-b5ed-426a-8b9f-cfa00d3b09db
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
Method <org.gradle.api.DefaultTask.getInputs()> has arguments/return type org.gradle.api.internal.TaskInputsInternal that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (DefaultTask.java:299)
Method <org.gradle.api.DefaultTask.getOutputs()> has arguments/return type org.gradle.api.internal.TaskOutputsInternal that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (DefaultTask.java:304)
Method <org.gradle.api.DefaultTask.getState()> has arguments/return type org.gradle.api.internal.tasks.TaskStateInternal that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (DefaultTask.java:274)
Method <org.gradle.api.DefaultTask.getTaskDependencies()> has arguments/return type org.gradle.api.internal.tasks.TaskDependencyInternal that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (DefaultTask.java:279)
Method <org.gradle.api.DefaultTask.getInputs()> has arguments/return type org.gradle.api.internal.TaskInputsInternal that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (DefaultTask.java:288)
Method <org.gradle.api.DefaultTask.getOutputs()> has arguments/return type org.gradle.api.internal.TaskOutputsInternal that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (DefaultTask.java:293)
Method <org.gradle.api.DefaultTask.getState()> has arguments/return type org.gradle.api.internal.tasks.TaskStateInternal that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (DefaultTask.java:273)
Method <org.gradle.api.DefaultTask.getTaskDependencies()> has arguments/return type org.gradle.api.internal.tasks.TaskDependencyInternal that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (DefaultTask.java:278)
Method <org.gradle.api.artifacts.repositories.ExclusiveContentRepository.forRepository(org.gradle.internal.Factory)> has arguments/return type org.gradle.internal.Factory that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (ExclusiveContentRepository.java:0)
Method <org.gradle.api.plugins.Convention.getExtensionsAsDynamicObject()> has arguments/return type org.gradle.internal.metaobject.DynamicObject that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Convention.java:0)
Method <org.gradle.api.plugins.JavaPluginConvention.getProject()> has arguments/return type org.gradle.api.internal.project.ProjectInternal that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (JavaPluginConvention.java:0)
Method <org.gradle.api.plugins.quality.Checkstyle.getAntBuilder()> has arguments/return type org.gradle.api.internal.project.IsolatedAntBuilder that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Checkstyle.java:123)
Method <org.gradle.api.plugins.quality.CodeNarc.getAntBuilder()> has arguments/return type org.gradle.api.internal.project.IsolatedAntBuilder that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (CodeNarc.java:127)
Method <org.gradle.api.plugins.quality.Pmd.getAntBuilder()> has arguments/return type org.gradle.api.internal.project.IsolatedAntBuilder that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Pmd.java:117)
Method <org.gradle.api.plugins.quality.Checkstyle.getAntBuilder()> has arguments/return type org.gradle.api.internal.project.IsolatedAntBuilder that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Checkstyle.java:122)
Method <org.gradle.api.plugins.quality.CodeNarc.getAntBuilder()> has arguments/return type org.gradle.api.internal.project.IsolatedAntBuilder that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (CodeNarc.java:125)
Method <org.gradle.api.plugins.quality.Pmd.getAntBuilder()> has arguments/return type org.gradle.api.internal.project.IsolatedAntBuilder that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Pmd.java:114)
Method <org.gradle.api.publish.maven.tasks.GenerateMavenPom.withCompileScopeAttributes(org.gradle.api.internal.attributes.ImmutableAttributes)> has arguments/return type org.gradle.api.internal.attributes.ImmutableAttributes that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (GenerateMavenPom.java:65)
Method <org.gradle.api.publish.maven.tasks.GenerateMavenPom.withRuntimeScopeAttributes(org.gradle.api.internal.attributes.ImmutableAttributes)> has arguments/return type org.gradle.api.internal.attributes.ImmutableAttributes that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (GenerateMavenPom.java:70)
Method <org.gradle.api.reporting.GenerateBuildDashboard.getInputReports()> has arguments/return type org.gradle.api.reporting.GenerateBuildDashboard$ReportState that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (GenerateBuildDashboard.java:73)
Method <org.gradle.api.tasks.AbstractCopyTask.getRootSpec()> has arguments/return type org.gradle.api.internal.file.copy.CopySpecInternal that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (AbstractCopyTask.java:173)
Method <org.gradle.api.reporting.GenerateBuildDashboard.getInputReports()> has arguments/return type org.gradle.api.reporting.GenerateBuildDashboard$ReportState that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (GenerateBuildDashboard.java:71)
Method <org.gradle.api.tasks.AbstractCopyTask.getRootSpec()> has arguments/return type org.gradle.api.internal.file.copy.CopySpecInternal that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (AbstractCopyTask.java:170)
Method <org.gradle.api.tasks.Copy.getRootSpec()> has arguments/return type org.gradle.api.internal.file.copy.CopySpecInternal that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Copy.java:69)
Method <org.gradle.api.tasks.Copy.getRootSpec()> has arguments/return type org.gradle.api.internal.file.copy.DestinationRootCopySpec that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Copy.java:88)
Method <org.gradle.api.tasks.Sync.getRootSpec()> has arguments/return type org.gradle.api.internal.file.copy.CopySpecInternal that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Sync.java:67)
Expand All @@ -25,12 +25,12 @@ Method <org.gradle.api.tasks.diagnostics.PropertyReportTask.getRenderer()> has a
Method <org.gradle.api.tasks.diagnostics.PropertyReportTask.setRenderer(org.gradle.api.tasks.diagnostics.internal.PropertyReportRenderer)> has arguments/return type org.gradle.api.tasks.diagnostics.internal.PropertyReportRenderer that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (PropertyReportTask.java:67)
Method <org.gradle.api.tasks.diagnostics.TaskReportTask.getRenderer()> has arguments/return type org.gradle.api.tasks.diagnostics.internal.ReportRenderer that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (TaskReportTask.java:69)
Method <org.gradle.api.tasks.diagnostics.TaskReportTask.setRenderer(org.gradle.api.tasks.diagnostics.internal.TaskReportRenderer)> has arguments/return type org.gradle.api.tasks.diagnostics.internal.TaskReportRenderer that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (TaskReportTask.java:76)
Method <org.gradle.api.tasks.javadoc.Groovydoc.getAntGroovydoc()> has arguments/return type org.gradle.api.internal.tasks.AntGroovydoc that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Groovydoc.java:199)
Method <org.gradle.api.tasks.javadoc.Groovydoc.setAntGroovydoc(org.gradle.api.internal.tasks.AntGroovydoc)> has arguments/return type org.gradle.api.internal.tasks.AntGroovydoc that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Groovydoc.java:208)
Method <org.gradle.api.tasks.javadoc.Groovydoc.getAntGroovydoc()> has arguments/return type org.gradle.api.internal.tasks.AntGroovydoc that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Groovydoc.java:198)
Method <org.gradle.api.tasks.javadoc.Groovydoc.setAntGroovydoc(org.gradle.api.internal.tasks.AntGroovydoc)> has arguments/return type org.gradle.api.internal.tasks.AntGroovydoc that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Groovydoc.java:207)
Method <org.gradle.api.tasks.scala.ScalaCompile.setCompiler(org.gradle.language.base.internal.compile.Compiler)> has arguments/return type org.gradle.language.base.internal.compile.Compiler that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (ScalaCompile.java:123)
Method <org.gradle.api.tasks.testing.Test.getTestFramework()> has arguments/return type org.gradle.api.internal.tasks.testing.TestFramework that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Test.java:915)
Method <org.gradle.api.tasks.testing.Test.getTestFrameworkProperty()> has arguments/return type org.gradle.api.internal.tasks.testing.TestFramework that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Test.java:910)
Method <org.gradle.api.tasks.testing.Test.testFramework(groovy.lang.Closure)> has arguments/return type org.gradle.api.internal.tasks.testing.TestFramework that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Test.java:919)
Method <org.gradle.api.tasks.testing.Test.getTestFramework()> has arguments/return type org.gradle.api.internal.tasks.testing.TestFramework that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Test.java:895)
Method <org.gradle.api.tasks.testing.Test.getTestFrameworkProperty()> has arguments/return type org.gradle.api.internal.tasks.testing.TestFramework that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Test.java:890)
Method <org.gradle.api.tasks.testing.Test.testFramework(org.gradle.api.Action)> has arguments/return type org.gradle.api.internal.tasks.testing.TestFramework that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Test.java:899)
Method <org.gradle.buildinit.tasks.InitBuild.getProjectLayoutRegistry()> has arguments/return type org.gradle.buildinit.plugins.internal.ProjectLayoutSetupRegistry that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (InitBuild.java:177)
Method <org.gradle.external.javadoc.OptionLessJavadocOptionFileOption.write(org.gradle.external.javadoc.internal.JavadocOptionFileWriterContext)> has arguments/return type org.gradle.external.javadoc.internal.JavadocOptionFileWriterContext that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (OptionLessJavadocOptionFileOption.java:0)
Method <org.gradle.language.assembler.tasks.Assemble.getOperationLoggerFactory()> has arguments/return type org.gradle.internal.operations.logging.BuildOperationLoggerFactory that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (Assemble.java:85)
Expand Down Expand Up @@ -67,7 +67,7 @@ Method <org.gradle.plugins.ide.idea.GenerateIdeaWorkspace.getXmlTransformer()> h
Method <org.gradle.plugins.signing.signatory.pgp.PgpSignatory.createSignatureGenerator()> has arguments/return type org.bouncycastle.openpgp.PGPSignatureGenerator that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (PgpSignatory.java:106)
Method <org.gradle.plugins.signing.signatory.pgp.PgpSignatoryFactory.createSignatory(java.lang.String, org.bouncycastle.openpgp.PGPSecretKey, java.lang.String)> has arguments/return type org.bouncycastle.openpgp.PGPSecretKey that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (PgpSignatoryFactory.java:73)
Method <org.gradle.plugins.signing.signatory.pgp.PgpSignatoryFactory.readSecretKey(java.lang.String, java.io.File)> has arguments/return type org.bouncycastle.openpgp.PGPSecretKey that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (PgpSignatoryFactory.java:121)
Method <org.gradle.util.CollectionUtils.partition(java.lang.Iterable, org.gradle.api.specs.Spec)> has arguments/return type org.gradle.internal.Pair that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (CollectionUtils.java:590)
Method <org.gradle.util.ConfigureUtil.configureSelf(groovy.lang.Closure, java.lang.Object, org.gradle.internal.metaobject.ConfigureDelegate)> has arguments/return type org.gradle.internal.metaobject.ConfigureDelegate that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (ConfigureUtil.java:179)
Method <org.gradle.util.GFileUtils.checksum(java.io.File, java.util.zip.Checksum)> has arguments/return type java.util.zip.Checksum that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (GFileUtils.java:279)
Method <org.gradle.util.GUtil.getOrDefault(java.lang.Object, org.gradle.internal.Factory)> has arguments/return type org.gradle.internal.Factory that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (GUtil.java:176)
Method <org.gradle.util.CollectionUtils.partition(java.lang.Iterable, org.gradle.api.specs.Spec)> has arguments/return type org.gradle.internal.Pair that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (CollectionUtils.java:656)
Method <org.gradle.util.ConfigureUtil.configureSelf(groovy.lang.Closure, java.lang.Object, org.gradle.internal.metaobject.ConfigureDelegate)> has arguments/return type org.gradle.internal.metaobject.ConfigureDelegate that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (ConfigureUtil.java:191)
Method <org.gradle.util.GFileUtils.checksum(java.io.File, java.util.zip.Checksum)> has arguments/return type java.util.zip.Checksum that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (GFileUtils.java:329)
Method <org.gradle.util.GUtil.getOrDefault(java.lang.Object, org.gradle.internal.Factory)> has arguments/return type org.gradle.internal.Factory that is not Gradle public API or primitive or built-in JDK classes or Groovy classes in (GUtil.java:195)
Loading