Exclude non-jar files when starting findbugs (Fix 1094,1745) #2167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes gradle#1094 This fixes gradle#1745 It has been reported in issues above that Findbugs will throw exception when non-jar files exist in classpath. The reason is that FindBugsSpecBuilder doesn't filter files in classpath but Findbugs can only recognize class files and jar files. This fix filters files to be provide to Findbugs. An unit test and an integration test have been provided.
|
@blindpirate Thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It has been reported in #1094 #1745 and old forum that Findbugs will throw exception when non-jar files exist in classpath. The reason is that FindBugsSpecBuilder doesn't filter files in classpath but Findbugs can only recognize
classfiles andjarfiles.This fix adds filter to
FindBugsSpecBuilderand provides unit test/integration test.Contributor Checklist
<subproject>/src/integTest) to verify changes from a user perspective<subproject>/src/test) to verify logic./gradlew quickCheck <impacted-subproject>:check