-
Notifications
You must be signed in to change notification settings - Fork 5k
Rework Java plugin #21200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Java plugin #21200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these refactoring changes are a good start towards improving this class, but I have some questions and suggestions.
subprojects/plugins/src/main/java/org/gradle/api/plugins/JavaPlugin.java
Outdated
Show resolved
Hide resolved
subprojects/plugins/src/main/java/org/gradle/api/plugins/JavaPlugin.java
Show resolved
Hide resolved
subprojects/plugins/src/main/java/org/gradle/api/plugins/JavaPlugin.java
Outdated
Show resolved
Hide resolved
subprojects/plugins/src/main/java/org/gradle/api/plugins/JavaPlugin.java
Outdated
Show resolved
Hide resolved
subprojects/plugins/src/main/java/org/gradle/api/plugins/JavaPlugin.java
Outdated
Show resolved
Hide resolved
subprojects/plugins/src/main/java/org/gradle/api/plugins/JavaPlugin.java
Outdated
Show resolved
Hide resolved
subprojects/plugins/src/main/java/org/gradle/api/plugins/JavaPlugin.java
Outdated
Show resolved
Hide resolved
10516ee
to
07ac5c0
Compare
My current task had me looking at this class and I saw some places that could use a bit of cleanup and reorginization. * Removed unused method parameters * Reduce usage of configuration name string constants and needless querying of configurations when we already had references elsewhere in class * Make some methods static where possible * Consolidate some short and related methods * Break up generic methods by moving code into relevant locations * Comment and javadoc formatting * Move test code into test suites block, use configuration names from test source set instead of static constants * Separate `configureConfigurations` into two methods, each creating one of `apiElements` and `runtimeElements`
07ac5c0
to
e1c5f0e
Compare
OK, I've already triggered a build for you. |
Pre-tested commit build failed. |
The failure seems to be my fault, looking. |
@bot-gradle test and merge |
OK, I've already triggered a build for you. |
My current task had me looking at this class and I saw some places that could use a bit of cleanup and reorganization.