Skip to content

Do not resolve classes dirs as a file tree #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2017
Merged

Do not resolve classes dirs as a file tree #2102

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b46d68e
Do not resolve classes dirs as a file tree
big-guy May 22, 2017
1da7e68
Reduce visibility of getCandidateClassFiles()
big-guy May 22, 2017
9f84acb
Clarify why we have a new method
big-guy May 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clarify why we have a new method
  • Loading branch information
@big-guy
big-guy committed May 23, 2017
commit 9f84acbbc9769de9c9d018c9c392e9b15e6812d3
2 changes: 2 additions & 0 deletions subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/FindBugs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,8 @@ public FileTree getSource() {
@PathSensitive(PathSensitivity.RELATIVE)
@InputFiles
protected FileCollection getCandidateClassFiles() {
// We need to resolve the classes into a set of files so @SkipWhenEmpty will work
// Otherwise, a collection of empty directories is not seen as "empty"
return getClasses().getAsFileTree();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this now different to annotating getClasses directly? If we do not filter by *.class then I would actually not add this new method but just use the old method as is and only change the convention mapping.

}

Expand Down