Allow setting --stacktrace with gradle property #18713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donat
commented
Oct 21, 2021
| When set to `all`, `summary` or `none`, Gradle will use different warning type display. See <<command_line_interface.adoc#sec:command_line_logging,Command-line logging options>> for details. | ||
| _Default is `summary`._ | ||
|
|
||
| `org.gradle.showstacktrace=(internal,all,full)`:: |
There was a problem hiding this comment.
I think using the entries from the ShowStacktrace enum as they are wouldn't look nice here, so I came up with simpler ones.
asodja
reviewed
Oct 21, 2021
...ects/logging/src/main/java/org/gradle/internal/logging/LoggingConfigurationBuildOptions.java
Outdated
Show resolved
Hide resolved
asodja
reviewed
Oct 21, 2021
subprojects/docs/src/docs/userguide/running-builds/build_environment.adoc
Show resolved
Hide resolved
asodja
approved these changes
Oct 21, 2021
|
Looks good to me, added just some suggestions to consider. |
big-guy
requested changes
Oct 21, 2021
...ects/logging/src/main/java/org/gradle/internal/logging/LoggingConfigurationBuildOptions.java
Show resolved
Hide resolved
subprojects/launcher/src/integTest/groovy/org/gradle/launcher/StacktraceIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
subprojects/launcher/src/integTest/groovy/org/gradle/launcher/StacktraceIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
...ects/logging/src/main/java/org/gradle/internal/logging/LoggingConfigurationBuildOptions.java
Show resolved
Hide resolved
...ects/logging/src/main/java/org/gradle/internal/logging/LoggingConfigurationBuildOptions.java
Outdated
Show resolved
Hide resolved
6dc14e3 to
1a44dc5
Compare
|
@big-guy ptal |
|
@bot-gradle test rFM |
|
OK, I've already triggered ReadyForMerge build for you. |
big-guy
approved these changes
Oct 27, 2021
|
@bot-gradle test and merge |
|
Your PR is queued. See the queue page for details. |
|
OK, I've already triggered a build for you. |
|
In 8.x this property is still there, but the documentation is missing #30278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13708