Disable incremental Kotlin compiler when running on Java 17 #17861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround to https://youtrack.jetbrains.com/issue/KT-47152 The fix is planned in Kotlin 1.5.30. If the fix lands before Java 17, then it would be preferable to upgrade. On the other hand, I was able to work around this issue in a smoke test by adding the required JVM arguments to the Kotlin compiler daemon here: 3fd0d21 At the same time, I am not able to apply such workaround within Gradle as was done previously with `--illegal-access=permit`: https://github.com/gradle/gradle/pull/17781/files#diff-66f4b61ab1b7cbf83f68849143ddd9934681ab75a5a68f26c6a51df7ad5c3f88 I do not understand why setting the same JVM args as in above smoke test in this place does not seem to do the trick here. Figuring this out instead, would be a better approach than disabling incremental Kotlin compiler on Java 17.
|
@bot-gradle test this |
|
OK, I've already triggered ReadyForMerge build for you. |
|
@rieske |
|
Yes. I'm setting the following 3fd0d21 |
|
@bot-gradle test and merge |
|
OK, I've already triggered a build for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround to https://youtrack.jetbrains.com/issue/KT-47152
The fix is planned in Kotlin 1.5.30.
If the fix lands before Java 17, then it would be preferable to
upgrade.
On the other hand, I was able to work around this issue in a smoke
test by adding the required JVM arguments to the Kotlin compiler daemon
here: 3fd0d21
At the same time, I am not able to apply such a workaround within
Gradle as was done previously with
--illegal-access=permit:https://github.com/gradle/gradle/pull/17781/files#diff-66f4b61ab1b7cbf83f68849143ddd9934681ab75a5a68f26c6a51df7ad5c3f88
I do not understand why setting the same JVM args as in above
smoke test in this place does not seem to do the trick here.
Figuring this out instead,would be a better approach than
disabling incremental Kotlin compiler on Java 17.