Fix scala incremental compilation #17845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning empty optionals instead of optionals with empty change sets in ExternalLookup hooks seems to fix the problem where deleted files are not detected when recompiling with incremental compilation. Also fix the usage custom java executables in fork options. Those were being lost since toolchains support was added for Scala.
Match Scala plugin behavior with how Groovy plugin behaves in this case. Adjust the test to assert for the executable.
|
@bot-gradle test this |
|
OK, I've already triggered ReadyForMerge build for you. |
|
@bot-gradle test and merge |
|
OK, I've already triggered a build for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #17818