Fall back to hashing the whole jar on unknown Kotlin metadata when extracting Kotlin's ABI #14834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
416f87f to
e3a61f5
Compare
Base automatically changed from
vv/kotlin-dsl/kotlin-multifile-class-compile-avoidance
to
master
October 13, 2020 08:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9224
If the metadata type of compiled Kotlin classes on buildscript's classpath can not be determined, fall back to using the content hash for that jar, turning off compile avoidance for it.
This can happen when the class on the script's classpath was compiled with some future version of Kotlin which has added new metadata types that this version of Gradle is not able to parse and thus does not know how or if it contributes to the ABI.