Transform precompiled plugins sample to publishing convention plugins sample #14241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sample Focus on the multi-repo use case and demonstrate how convention plugins can be published and consumed from another project.
Base automatically changed from
vv/inline-convention-plugins-sample-buildSrc
to
master
August 21, 2020 11:45
jjohannes
suggested changes
Aug 21, 2020
subprojects/docs/src/samples/build-organization/publishing-convention-plugins/README.adoc
Show resolved
Hide resolved
subprojects/docs/src/samples/build-organization/publishing-convention-plugins/README.adoc
Outdated
Show resolved
Hide resolved
subprojects/docs/src/samples/build-organization/publishing-convention-plugins/README.adoc
Outdated
Show resolved
Hide resolved
subprojects/docs/src/samples/build-organization/publishing-convention-plugins/README.adoc
Outdated
Show resolved
Hide resolved
subprojects/docs/src/samples/build-organization/publishing-convention-plugins/README.adoc
Outdated
Show resolved
Hide resolved
subprojects/docs/src/samples/build-organization/publishing-convention-plugins/README.adoc
Outdated
Show resolved
Hide resolved
subprojects/docs/src/samples/build-organization/publishing-convention-plugins/README.adoc
Outdated
Show resolved
Hide resolved
...ples/build-organization/publishing-convention-plugins/groovy/convention-plugins/build.gradle
Outdated
Show resolved
Hide resolved
| // tag::plugins[] | ||
| plugins { | ||
| id("myproject.java-conventions") | ||
| id("com.myorg.java-conventions") |
There was a problem hiding this comment.
The integration test setup below does not follow what we would recommend today. Following what we do here:
https://github.com/gradle/gradle/blob/418a06a84863e20bebcdebc924761e6312d53626/subprojects/docs/src/samples/java/modules-multi-project-with-integration-tests/kotlin/buildSrc/src/main/kotlin/myproject.java-conventions.gradle.kts
It could look like this:
val integrationTest by sourceSets.creating
configurations[integrationTest.implementationConfigurationName].extendsFrom(configurations.testImplementation.get())
configurations[integrationTest.runtimeOnlyConfigurationName].extendsFrom(configurations.testRuntimeOnly.get())
val integrationTestTask = tasks.register<Test>("integrationTest") {
testClassesDirs = integrationTest.output.classesDirs
classpath = integrationTest.runtimeClasspath
shouldRunAfter(tasks.test)
}
dependencies {
"integrationTestImplementation"(project)
}
…vention-plugins/README.adoc Co-authored-by: Jendrik Johannes <[email protected]>
…vention-plugins/README.adoc Co-authored-by: Jendrik Johannes <[email protected]>
…vention-plugins/README.adoc Co-authored-by: Jendrik Johannes <[email protected]>
…vention-plugins/README.adoc Co-authored-by: Jendrik Johannes <[email protected]>
…vention-plugins/README.adoc Co-authored-by: Jendrik Johannes <[email protected]>
…vention-plugins/README.adoc Co-authored-by: Jendrik Johannes <[email protected]>
…vention-plugins/README.adoc Co-authored-by: Jendrik Johannes <[email protected]>
…vention-plugins/README.adoc Co-authored-by: Jendrik Johannes <[email protected]>
…vention-plugins/README.adoc Co-authored-by: Jendrik Johannes <[email protected]>
…vention-plugins/README.adoc Co-authored-by: Jendrik Johannes <[email protected]>
jjohannes
approved these changes
Aug 24, 2020
Co-authored-by: Jendrik Johannes <[email protected]>
Co-authored-by: Jendrik Johannes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus on the multi-repo use case and demonstrate how convention plugins can be published and consumed from another project.