Allow property replacement in version strings in the plugins block
#9827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@big-guy @JLLeitschuh To obtain closure, I've merged this to master pre-review. I'll leave it in your capable hands to decide: accept/revert/improve. Thanks!!!! |
JLLeitschuh
reviewed
Jun 29, 2019
| 2 | 'id("noop").version("part-${unknown}-part")' | "Could not get unknown property 'unknown'" | ||
| } | ||
|
|
||
|
|
thevery
reviewed
Sep 10, 2022
| verifyPluginApplied('2.0') | ||
| } | ||
|
|
||
| def "can specify plugin version using buildSrc constant"() { |
There was a problem hiding this comment.
pardon for necro-posting, but this test is exactly the same as previous
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1697 (currently most 👍 for Gradle Build Tool)
There remain some limitations in the implementation.
pluginsblock.Projectinstance into thepluginsblock. This is mitigated by:buildscriptblock